Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all terraform=true hardcoded tags #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucasmacedot
Copy link
Contributor

@lucasmacedot lucasmacedot commented Jan 5, 2025

Terraform errors if the default_tags block have the same tag as the tags on a resource.
A better way to manage this is to put all tags on the default_tags block, and pass tags specific to modules on the tags variable

image

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@lucasmacedot lucasmacedot self-assigned this Jan 5, 2025
Copy link
Member

@Renatovnctavares Renatovnctavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which terraform version comes with the default_tags - can we make it retro-compatible?
leaving tags variable defined and we can send an empty value in case it is needed

is it worth?

variable "tags" {
description = "Map of tags that will be added to created resources. By default resources will be tagged with terraform=true."
type = map(string)
default = {
"Terraform" = true
}
}

@adenot what do you think?

@adenot
Copy link
Member

adenot commented Jan 23, 2025

which terraform version comes with the default_tags - can we make it retro-compatible? leaving tags variable defined and we can send an empty value in case it is needed

is it worth?

variable "tags" { description = "Map of tags that will be added to created resources. By default resources will be tagged with terraform=true." type = map(string) default = { "Terraform" = true } }

@adenot what do you think?

yes, adding the default for tags as the existing tag (terraform=true) will avoid some unnecessary drift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants